Login: fix crash when dismissing Google view - #8012
Merged
Merged
Conversation
aerych
reviewed
Oct 19, 2017
Contributor
There was a problem hiding this comment.
Nitpicky on style but maybe we could align the let statements?
Contributor
|
Howdy Nate! |
when its time.
nheagy
force-pushed
the
fix/google-cancel-crash
branch
from
October 19, 2017 21:38
a13da5e to
9858017
Compare
nheagy
force-pushed
the
fix/google-cancel-crash
branch
from
October 20, 2017 04:57
9858017 to
8faa2c3
Compare
Contributor
Author
|
@aerych I plan to merge this in the morning, unless you see something else super bad 😜 |
Contributor
Author
|
Thanks @aerych! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs #7675
To test:
Needs review: @aerych
Note: this was branched from #8010 and will include its changes until merged.